Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JaCoCo offline instrumentation #3495

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Dec 16, 2024

It incorrectly affects manifest calculation which leads to follow-up issues with aemanalyser-m-p and is generally not recommended (https://www.eclemma.org/jacoco/trunk/doc/instrument-mojo.html)

It was originally introduced for compatibility with PowerMock but that is no longer used.

This closes #3494

@kwin kwin requested a review from davidjgonzalez December 16, 2024 16:45
@kwin kwin force-pushed the bugfix/remove-offline-instrumentation branch from 80590ab to 79b7280 Compare December 16, 2024 17:02
It incorrectly affects manifest calculation which leads to follow-up
issues with aemanalyser-m-p and is generally not recommended
(https://www.eclemma.org/jacoco/trunk/doc/instrument-mojo.html)

It was originally introduced for compatibility with PowerMock but that
is no longer used.

Use a common execution data file for IT/UT as it is written to in append
mode by default (jacoco/jacoco#1676)

This closes #3494
@kwin kwin force-pushed the bugfix/remove-offline-instrumentation branch from 79b7280 to b722ec5 Compare January 2, 2025 11:45
@kwin kwin merged commit e9bc657 into master Jan 2, 2025
17 of 19 checks passed
@kwin kwin deleted the bugfix/remove-offline-instrumentation branch January 2, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove offline instrumentation with Jacoco
1 participant